Contributing

Contributions and issues are most welcome! All issues and pull requests are handled through GitHub. Also, please check for any existing issues before filing a new one. If you have a great idea but it involves big changes, please file a ticket before making a pull request! We want to make sure you don’t spend your time coding something that might not fit the scope of the project.

Running the tests

To run in a container

Use vscode devcontainer as follows:

$ git clone git://github.com/gilesknap/gphotos-sync.git
$ vscode gphotos-sync
Click on 'Reopen in Container' when prompted
In a vscode Terminal:
$ tox -p

To run locally

Get the source source code and run the unit tests directly on your workstation as follows:

$ git clone git://github.com/gilesknap/gphotos-sync.git
$ cd gphotos-sync
$ virtualenv .venv
$ source .venv/bin/activate
$ pip install -e .[dev]
$ tox -p

In both cases tox -p runs in parallel the following checks:

Build Spinx Documentation

run pytest on all tests in ./tests

run mypy linting on all files in ./src ./tests

run pre-commit checks:

run flake8 style checks against all source

run black formatting checks against all source

While 100% code coverage does not make a library bug-free, it significantly reduces the number of easily caught bugs! Please make sure coverage remains the same or is improved by a pull request!

Code Styling

The code in this repository conforms to standards set by the following tools:

black for code formatting
flake8 for style checks
isort for import ordering
mypy for static type checking

These checks will be run by pre-commit. You can either choose to run these tests on all files tracked by git:

$ tox -e pre-commit,mypy

Or you can install a pre-commit hook that will run each time you do a git commit on just the files that have changed:

$ pre-commit install

Docstrings are pre-processed using the Sphinx Napoleon extension. As such, google-style is considered as standard for this repository. Please use type hints in the function signature for types. For example:

def func(arg1: str, arg2: int) -> bool:
    """Summary line.

    Extended description of function.

    Args:
        arg1: Description of arg1
        arg2: Description of arg2

    Returns:
        Description of return value
    """
    return True

Documentation

Documentation is contained in the docs directory and extracted from docstrings of the API.

Docs follow the underlining convention:

Headling 1 (page title)
=======================

Heading 2
---------

Heading 3
~~~~~~~~~

You can build the docs from the project directory by running:

$ tox -e docs
$ firefox build/html/index.html

Release Process

To make a new release, please follow this checklist:

Choose a new PEP440 compliant release number
Git tag the version
Push to GitHub and the actions will make a release on pypi
Push to internal gitlab and do a dls-release.py of the tag
Check and edit for clarity the autogenerated GitHub release

Updating the tools

This module is merged with the dls-python3-skeleton. This is a generic Python project structure which provides a means to keep tools and techniques in sync between multiple Python projects. To update to the latest version of the skeleton, run:

$ git pull https://github.com/dls-controls/dls-python3-skeleton skeleton

Any merge conflicts will indicate an area where something has changed that conflicts with the setup of the current module. Check the closed pull requests of the skeleton module for more details.